The latest updates on your projects. Learn more about Vercel for Git ↗︎

@dario-piotrowicz do we have updates here? 👀

Hey @ovflowd 👋

Sorry for keeping the PR lingering, there are a few smaller issues we addressed in our adapter (that I need to reflect here), and also ISR should be coming soon (@vicb can provide more context)

Besides that I just need to rebase the PR, the only significant issue remaining should be filesystem access, but I wanted to clarify that with you, I'll drop you a message today to clarify things

(PS: I hope the PR is not bothering you 🙇, if you want I can close it and reopen it when we're ready?)

Sorry for keeping the PR lingering, there are a few smaller issues we addressed in our adapter (that I need to reflect here), and also ISR should be coming soon (@vicb can provide more context)

This is awesome news. Excited to hear from @vicb

Besides that I just need to rebase the PR, the only significant issue remaining should be filesystem access, but I wanted to clarify that with you, I'll drop you a message today to clarify things

I believe we sorted that out on Slack 🖖

(PS: I hope the PR is not bothering you 🙇, if you want I can close it and reopen it when we're ready?)

Not at all <3

I've resolved #7383 (comment). With that in mind, I'd love to merge this tomorrow (or sooner, if you'd like) if there are no objections¹. WDYT?

I've resolved #7383 (comment). With that in mind, I'd love to merge this tomorrow (or sooner, if you'd like) if there are no objections1. WDYT?

Thank you very much @avivkeller 🫶

With that resolved I think this should (finally! sorry about how long this took! 😅) be ready to be merged! 😄 🥳

I'm also happy to merge this as long as there are no objections 😃

It's your PR, so feel free to merge whenever you'd like. Honestly, Any changes could be done in a follow up.

Finally made it! thanks a lot everyone for the reviews and the support on this one! 🫶

This PR worries me; It got 0 approvals from web-infra when it is pretty much an infrastructure PR. Ideally this should have gotten an approval from at least me, @bmuenzenmeyer or @flakey5 or @MattIPv4 or @canerakdas. But it got none :/

Anyhow, I believe my concerns can be addressed in a follow-up PR; I'd just really appreciate if they get done; I wouldn't mind doing'em myself to be honest.

That's on me. I encouraged the merging of this PR - and should've checked that web-infra got a chance to review.

Which of your concerns weren't addressed? I think the postinstall concern is resolved (Postinstall scripts are no longer in use).

Which of your concerns weren't addressed? I think the postinstall concern is resolved (Postinstall scripts are no longer in use).

That's OK; My concern was a base template file existing; Otherwise if I never run any of the run commands, or just do npx next dev it will just break. The run commands technically speaking should be as simple as possible.

I still wonder if we accidentally have too much complexity on the repository. I truly think we gotta audit the repository's complexity and attempt to trim it down. (Monorepo aside, cause that's fine)

That's on me.

That's definitely on me as well (more than you I'd argue) 🥹 , sorry @ovflowd 🙇 , given your last approval (note that I addressed the comments that approval refers to) which is from a web-infra folk and the rest of the approvals I didn't really see a concern about the merge.

Yes I agree that this probably should have gotten some more web-infra visibility 🙇

That's on me.

That's definitely on me as well (more than you I'd argue) 🥹 , sorry @ovflowd 🙇 , given your last approval (note that I addressed the comments that approval refers to) which is from a web-infra folk and the rest of the approvals I didn't really see a concern about the merge.

Yes I agree that this probably should have gotten some more web-infra visibility 🙇

Indeed, I didn't realise I approved; That's on me, apologies for calling out there was no approval when there was indeed one. It's all good, and it's minor :)

Anyhow, I'm super proud of the work here ✨

Indeed, I didn't realise I approved; That's on me, apologies for calling out there was no approval when there was indeed one. It's all good, and it's minor :)

Thanks! 🫶

(But again, sorry, I should have checked with you before merging 🙇)

Anyhow, I'm super proud of the work here ✨

Thanks, and thanks for all the help with landing this 🫶

Anyhow, I believe my concerns can be addressed in a follow-up PR; I'd just really appreciate if they get done; I wouldn't mind doing'em myself to be honest.

That's OK; My concern was a base template file existing; Otherwise if I never run any of the run commands, or just do npx next dev it will just break. The run commands technically speaking should be as simple as possible.

@ovflowd as I mentioned in the conversation there I did try what you suggested but that didn't work, and on the top of my head I can't think of a way to make it work without a postinstall script, I'm happy to help here but I am not sure how, would you mind giving that a quick try on your end? 🙏